[GitHub] [shiro] bmhm commented on issue #58: [SHIRO-337] basic cdi support

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [shiro] bmhm commented on issue #58: [SHIRO-337] basic cdi support

GitBox
bmhm commented on issue #58: [SHIRO-337] basic cdi support
URL: https://github.com/apache/shiro/pull/58#issuecomment-577407176
 
 
   Great, I think 99% of your github comment should directly go into javadocs.
   
   Well, performance claims should have a test. I have no reason to not believe you, but I just wouldn't keep that dangling comment and just put the explanation into the javadocs.
   
   About this statement however:
   
   > +-0 for line 40 change, #codestyle
   
   Uhm my first commits were for the maven checkstyle plugin. It got rejected because I used a guard statement instead of an else. That's also just style. But it is not consistent with the rest of the code.
   
   I learned that consistency beats style, and I haven't seen any casting done this way in other source files. Also, without any variable, it creates a lot of nesting. That's the reason. Not because I don't like it or wouldn't understand it. It's just about consistency which helps in keeping a project maintainable. 😉

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services