[jira] [Commented] (SHIRO-408) Specifying memberOf for ActiveDirectoryRealm LDAP search

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SHIRO-408) Specifying memberOf for ActiveDirectoryRealm LDAP search

Francois Papon (Jira)

    [ https://issues.apache.org/jira/browse/SHIRO-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020908#comment-17020908 ]

Benjamin Marwell commented on SHIRO-408:
----------------------------------------

Hi [~vines]

 

I think this is a very interesting patch. Could you create a PR on github? Or if you tell me your username and email, I can create the PR with split committer/author (you being the author).

> Specifying memberOf for ActiveDirectoryRealm LDAP search
> --------------------------------------------------------
>
>                 Key: SHIRO-408
>                 URL: https://issues.apache.org/jira/browse/SHIRO-408
>             Project: Shiro
>          Issue Type: Improvement
>          Components: Realms
>            Reporter: John Vines
>            Priority: Major
>              Labels: patch
>         Attachments: SHIRO-408-1.2.x.patch, SHIRO-408-trunk.patch
>
>
> searchCtls.setReturningAttributes(new String[] {"memberOf"});
> This line will do the search with only returning the information the call in getRoleNamesForUser needs. It's a minor performance improvement.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)