[jira] [Commented] (SHIRO-559) shiro-guice violates the JEE specification

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SHIRO-559) shiro-guice violates the JEE specification

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SHIRO-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989455#comment-15989455 ]

Brian Demers commented on SHIRO-559:
------------------------------------

This should be a pretty easy issue to fix. Send us a pull request if possible :)

> shiro-guice violates the JEE specification
> ------------------------------------------
>
>                 Key: SHIRO-559
>                 URL: https://issues.apache.org/jira/browse/SHIRO-559
>             Project: Shiro
>          Issue Type: Bug
>          Components: Integration: Guice
>    Affects Versions: 1.2.3
>            Reporter: Krassimir
>
> The [DestroyableRegistry.destroy() method (line 65/66)|http://svn.apache.org/repos/asf/shiro/tags/shiro-root-1.2.4/support/guice/src/main/java/org/apache/shiro/guice/ShiroModule.java], annotated with @PreDestroy throws a checked exception which violates the [specification|http://docs.oracle.com/javaee/7/api/javax/annotation/PreDestroy.html], which makes it impossible for a shiro-guice powered application to be deployed on Glassfish.
> Here is the exact error message:
> {code}
> The lifecycle method [destroy] must not throw a checked exception. Related annotation information: annotation [javax.annotation.PreDestroy()] on annotated element [public void org.apache.shiro.guice.ShiroModule$1.destroy() throws java.lang.Exception] of type [METHOD] The lifecycle method [destroy] must not throw a checked exception. Related annotation information: annotation [javax.annotation.PreDestroy()] on annotated element [public void org.apache.shiro.guice.ShiroModule$1.destroy() throws java.lang.Exception] of type [METHOD]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)