[jira] [Commented] (SHIRO-608) Use a ServiceLoader to discover WebEnvironments

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (SHIRO-608) Use a ServiceLoader to discover WebEnvironments

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SHIRO-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990504#comment-15990504 ]

ASF GitHub Bot commented on SHIRO-608:
--------------------------------------

GitHub user bdemers reopened a pull request:

    https://github.com/apache/shiro/pull/53

    Use a ServiceLoader to discover WebEnvironments

    The idea here is to lessen the touch points for frameworks when integrating with Shiro.  A property file and a `WebEnvironment` implementation should be all that is needed. The WebEnvironment can then provide additional defaults or customizations specific to that framework.
   
    https://issues.apache.org/jira/browse/SHIRO-608

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bdemers/shiro environment-service

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/shiro/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
   
----
commit fca1fbad85d28438378cee31e5104a6fd37fde5a
Author: Brian Demers <[hidden email]>
Date:   2016-12-16T19:21:24Z

    IDEA: use a ServiceLoader to discover WebEnvironments

commit a993801fbe8ef1cf7467a16d08c5790a3029b990
Author: Brian Demers <[hidden email]>
Date:   2017-01-11T15:35:58Z

    Added test for EnvironmentLoader when using a ServiceLoader
   
    Signed-off-by: Brian Demers <[hidden email]>

----


> Use a ServiceLoader to discover WebEnvironments
> -----------------------------------------------
>
>                 Key: SHIRO-608
>                 URL: https://issues.apache.org/jira/browse/SHIRO-608
>             Project: Shiro
>          Issue Type: Bug
>          Components: Configuration, Web
>            Reporter: Brian Demers
>            Assignee: Brian Demers
>             Fix For: 1.4.0
>
>
> The idea here is to lessen the touch points for frameworks when integrating with Shiro. A property file and a WebEnvironment implementation should be all that is needed. The {{WebEnvironment}} can then provide additional defaults or customizations specific to that framework.
> PR: https://github.com/apache/shiro/pull/53



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Loading...