[jira] [Commented] (SHIRO-617) ShiroFilter initialize WebEnvironment on startup

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (SHIRO-617) ShiroFilter initialize WebEnvironment on startup

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SHIRO-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940465#comment-15940465 ]

Brian Demers commented on SHIRO-617:

Possibly, we would need to cover the destroy use case as well.

I don't know enough about the OSGI concerns, to comment, but open a pull request, and reference this JIRA issue, and the two will be connected, i'm sure we can get someone to look it over!

> ShiroFilter initialize WebEnvironment on startup
> ------------------------------------------------
>                 Key: SHIRO-617
>                 URL: https://issues.apache.org/jira/browse/SHIRO-617
>             Project: Shiro
>          Issue Type: Improvement
>            Reporter: Marco Descher
>            Priority: Minor
> Following up to http://shiro-developer.582600.n2.nabble.com/Deprecation-of-org-apache-shiro-web-servlet-IniShiroFilter-td7205283.html
> I am integrating shiro into our OSGI based product. The requirement to register the WebEnvironment listener on startup is a real problem.
> ""it would be extremely easy to create a subclass of ShiroFilter that
> initializes the necessary WebEnvironment at filter startup.  If you
> can't use a servlet context listener, this would be the next best
> thing and would work as expected.  The EnvironmentLoaderListener is
> extremely minimal on purpose - the real work is done in the parent
> class, which can be used from a Filter easily. ""

This message was sent by Atlassian JIRA