[jira] [Commented] (SHIRO-617) ShiroFilter initialize WebEnvironment on startup

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SHIRO-617) ShiroFilter initialize WebEnvironment on startup

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SHIRO-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942882#comment-15942882 ]

ASF GitHub Bot commented on SHIRO-617:
--------------------------------------

GitHub user col-panic opened a pull request:

    https://github.com/apache/shiro/pull/59

    ShiroFilter initialize WebEnvironment on startup

    Please consider the pull request, as documented in https://issues.apache.org/jira/browse/SHIRO-617
   
    The Reverted patch was wrongly made against a 1.3.2. The relevant patch is dc3da92

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/col-panic/shiro master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/shiro/pull/59.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #59
   
----
commit 4e37144e52a5260a12f3ab02625924b845990589
Author: Marco Descher <[hidden email]>
Date:   2017-03-27T08:51:38Z

    [SHIRO-617] ShiroFilter initialize WebEnvironment on startup

commit e146e87bf94faa9dbe4cd8b8b93bba4a9a975441
Author: Marco Descher <[hidden email]>
Date:   2017-03-27T08:53:21Z

    Revert "[SHIRO-617] ShiroFilter initialize WebEnvironment on startup"
   
    This reverts commit 4e37144e52a5260a12f3ab02625924b845990589.

commit dc3da92a9136a5fb32608126a25ca59841980512
Author: Marco Descher <[hidden email]>
Date:   2017-03-27T08:57:07Z

    [SHIRO-617] ShiroFilter initialize WebEnvironment on startup

----


> ShiroFilter initialize WebEnvironment on startup
> ------------------------------------------------
>
>                 Key: SHIRO-617
>                 URL: https://issues.apache.org/jira/browse/SHIRO-617
>             Project: Shiro
>          Issue Type: Improvement
>            Reporter: Marco Descher
>            Priority: Minor
>
> Following up to http://shiro-developer.582600.n2.nabble.com/Deprecation-of-org-apache-shiro-web-servlet-IniShiroFilter-td7205283.html
> I am integrating shiro into our OSGI based product. The requirement to register the WebEnvironment listener on startup is a real problem.
> ""it would be extremely easy to create a subclass of ShiroFilter that
> initializes the necessary WebEnvironment at filter startup.  If you
> can't use a servlet context listener, this would be the next best
> thing and would work as expected.  The EnvironmentLoaderListener is
> extremely minimal on purpose - the real work is done in the parent
> class, which can be used from a Filter easily. ""



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)