[jira] [Commented] (SHIRO-618) Spring Boot Web Starter- Autoconfiguration for Realm and ShiroFilterChainDefinition

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SHIRO-618) Spring Boot Web Starter- Autoconfiguration for Realm and ShiroFilterChainDefinition

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SHIRO-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936781#comment-15936781 ]

Marc G. commented on SHIRO-618:
-------------------------------

Hi Brian,

ShiroFilterChainDefinition:
* Maybe the /** should be configured via properties?

Realm:

* We can create a custom condition annotation to check if the shiro.ini file is present and use it instead of a default TextConfigurationRealm.
 https://github.com/spring-projects/spring-boot/blob/master/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/SpringBootCondition.java

* We can throw a specific exception and provide a proper exception message
  http://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#_startup_failure



> Spring Boot Web Starter- Autoconfiguration for Realm and ShiroFilterChainDefinition
> -----------------------------------------------------------------------------------
>
>                 Key: SHIRO-618
>                 URL: https://issues.apache.org/jira/browse/SHIRO-618
>             Project: Shiro
>          Issue Type: Improvement
>            Reporter: Marc G.
>
> After adding the spring-boot-web-starter you got the exception that two beans are missing.
> * Realm
> * ShiroFilterChainDefinition
> Are they not defined on purpose? Both can be provided as a default with @ConditionalOnMissingBean.
> A default TextConfigurationRealm could be configured with properties.
> Providing defaults makes it easier to get startet.
> I could provide a pull request if desired.
> What do you think?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)