[jira] [Commented] (SHIRO-618) Spring Boot Web Starter- Autoconfiguration for Realm and ShiroFilterChainDefinition

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SHIRO-618) Spring Boot Web Starter- Autoconfiguration for Realm and ShiroFilterChainDefinition

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SHIRO-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947691#comment-15947691 ]

ASF GitHub Bot commented on SHIRO-618:
--------------------------------------

GitHub user MarcGiffing opened a pull request:

    https://github.com/apache/shiro/pull/62

    SHIRO-618 - Autoconfiguration for Realm and ShiroFilterChainDefinition

    * automatic realm configuration for shiro.ini / META-INF/shiro.ini
    * providing a detailed exception with the help of Spring Boots AbstractFailureAnalyzer if no realm bean is configured


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MarcGiffing/shiro SHIRO-618

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/shiro/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #62
   
----
commit fbbd83dc941b98dda6a747a93a1e23f675b14f0c
Author: marcgiffing <[hidden email]>
Date:   2017-03-25T15:14:40Z

    SHIRO-618 - Autoconfiguration for Realm and ShiroFilterChainDefinition

----


> Spring Boot Web Starter- Autoconfiguration for Realm and ShiroFilterChainDefinition
> -----------------------------------------------------------------------------------
>
>                 Key: SHIRO-618
>                 URL: https://issues.apache.org/jira/browse/SHIRO-618
>             Project: Shiro
>          Issue Type: Improvement
>            Reporter: Marc G.
>
> After adding the spring-boot-web-starter you got the exception that two beans are missing.
> * Realm
> * ShiroFilterChainDefinition
> Are they not defined on purpose? Both can be provided as a default with @ConditionalOnMissingBean.
> A default TextConfigurationRealm could be configured with properties.
> Providing defaults makes it easier to get startet.
> I could provide a pull request if desired.
> What do you think?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)