[jira] Resolved: (JSEC-8) Change instance variables from private to protected

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (JSEC-8) Change instance variables from private to protected

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/JSEC-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Les Hazlewood resolved JSEC-8.
------------------------------

    Resolution: Won't Fix

This isn't a good idea to do on a sweeping level, per Joshua Bloch's Effectie Java, Item #13 - it breaks the principals of encapsulation and what that means for maintainability over time in a widely-used framework.  While the protected modifer is good in some circumstances, it shouldn't be enforced across the board for all classes.

> Change instance variables from private to protected
> ---------------------------------------------------
>
>                 Key: JSEC-8
>                 URL: https://issues.apache.org/jira/browse/JSEC-8
>             Project: JSecurity
>          Issue Type: Improvement
>          Components: Specification API
>            Reporter: Alan Cabrera
>             Fix For: 1.0
>
>
> Currently most instance variables are private, which limits options when the classes are extended. We are standardizing on protected from now on, but the existing classes should be updated.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.